Browse Source

Merge pull request #299 from piotranon/master

generating long number fix
Shalvah 3 năm trước cách đây
mục cha
commit
04ac91453d

+ 4 - 4
src/Extracting/ParsesValidationRules.php

@@ -339,13 +339,13 @@ trait ParsesValidationRules
                  */
                 case 'digits':
                     $parameterData['description'] .= ' ' . $this->getDescription($rule, [':digits' => $arguments[0]]);
-                    $parameterData['setter'] = fn() => $this->getFaker()->randomNumber($arguments[0], true);
-                    $parameterData['type'] = 'number';
+                    $parameterData['setter'] = fn() => $this->getFaker()->numerify(str_repeat("#", $arguments[0]));
+                    $parameterData['type'] = 'string';
                     break;
                 case 'digits_between':
                     $parameterData['description'] .= ' ' . $this->getDescription($rule, [':min' => $arguments[0], ':max' => $arguments[1]]);
-                    $parameterData['setter'] = fn() => $this->getFaker()->randomNumber($this->getFaker()->numberBetween(...$arguments), true);
-                    $parameterData['type'] = 'number';
+                    $parameterData['setter'] = fn() => $this->getFaker()->numerify(str_repeat("#", rand($arguments[0], $arguments[1])));
+                    $parameterData['type'] = 'string';
                     break;
 
                 /**

+ 2 - 2
tests/Unit/ValidationRuleParsingTest.php

@@ -226,7 +226,7 @@ class ValidationRuleParsingTest extends BaseLaravelTest
             [],
             [
                 'description' => "Must be 8 digits.",
-                'type' => 'number',
+                'type' => 'string',
             ],
         ];
         yield 'digits_between' => [
@@ -234,7 +234,7 @@ class ValidationRuleParsingTest extends BaseLaravelTest
             [],
             [
                 'description' => "Must be between 2 and 8 digits.",
-                'type' => 'number',
+                'type' => 'string',
             ],
         ];
         yield 'alpha' => [