Browse Source

Experimental: don't URL-encode Postman query parameters (closes #442)

shalvah 2 years ago
parent
commit
df4d86fa1d

+ 2 - 2
src/Writing/PostmanCollectionWriter.php

@@ -293,8 +293,8 @@ class PostmanCollectionWriter
                     // Going with the first to also support object query parameters
                     // See https://www.php.net/manual/en/function.parse-str.php
                     $query[] = [
-                        'key' => urlencode("{$name}[$index]"),
-                        'value' => urlencode($value),
+                        'key' => "{$name}[$index]",
+                        'value' => $value,
                         'description' => strip_tags($parameterData->description),
                         // Default query params to disabled if they aren't required and have empty values
                         'disabled' => !$parameterData->required && empty($parameterData->example),

+ 2 - 2
tests/Unit/PostmanCollectionWriterTest.php

@@ -130,13 +130,13 @@ class PostmanCollectionWriterTest extends TestCase
             'disabled' => false,
         ], $variableData[0]);
         $this->assertEquals([
-            'key' => urlencode('filters[0]'),
+            'key' => 'filters[0]',
             'value' => '34',
             'description' => 'Filters',
             'disabled' => false,
         ], $variableData[1]);
         $this->assertEquals([
-            'key' => urlencode('filters[1]'),
+            'key' => 'filters[1]',
             'value' => '12',
             'description' => 'Filters',
             'disabled' => false,