Browse Source

Merge pull request #628 from sangnguyenplus/patch-1

Ignore upgrade check if user hasn't published config yet
Shalvah 2 năm trước cách đây
mục cha
commit
ed7b0854c5

+ 5 - 0
src/Commands/GenerateDocumentation.php

@@ -155,6 +155,11 @@ class GenerateDocumentation extends Command
 
         $this->info("Checking for any pending upgrades to your config file...");
         try {
+            if (! $this->laravel['files']->exists($this->laravel->configPath("{$this->configName}.php"))) {
+                $this->info("No config file to upgrade.");
+                return;
+            }
+
             $upgrader = Upgrader::ofConfigFile("config/{$this->configName}.php", __DIR__ . '/../../config/scribe.php')
                 ->dontTouch(
                     'routes', 'example_languages', 'database_connections_to_transact', 'strategies', 'laravel.middleware',

+ 8 - 2
tests/GenerateDocumentation/BehavioursTest.php

@@ -2,6 +2,7 @@
 
 namespace Knuckles\Scribe\Tests\GenerateDocumentation;
 
+use Illuminate\Support\Facades\File as FileFacade;
 use Illuminate\Support\Facades\Route as RouteFacade;
 use Knuckles\Scribe\Commands\GenerateDocumentation;
 use Knuckles\Scribe\Scribe;
@@ -213,8 +214,13 @@ class BehavioursTest extends BaseLaravelTest
         config(["scribe_test" => require "config/scribe_test.php"]);
 
         $output = $this->artisan('scribe:generate', ['--config' => 'scribe_test']);
-        $this->assertStringContainsString("Checking for any pending upgrades to your config file...", $output);
-        $this->assertStringContainsString("`logo` will be added", $output);
+
+        if (! FileFacade::exists(config_path("scribe.php"))) {
+            $this->assertStringContainsString("No config file to upgrade.", $output);
+        } else {
+            $this->assertStringContainsString("Checking for any pending upgrades to your config file...", $output);
+            $this->assertStringContainsString("`logo` will be added", $output);
+        }
 
         $output = $this->artisan('scribe:generate', ['--config' => 'scribe_test', '--no-upgrade-check' => true]);
         $this->assertStringNotContainsString("Checking for any pending upgrades to your config file...", $output);