ExtractorTest.php 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432
  1. <?php
  2. namespace Knuckles\Scribe\Tests\Unit;
  3. use DMS\PHPUnitExtensions\ArraySubset\ArraySubsetAsserts;
  4. use Illuminate\Routing\Route;
  5. use Knuckles\Camel\Extraction\ExtractedEndpointData;
  6. use Knuckles\Camel\Extraction\Parameter;
  7. use Knuckles\Scribe\Extracting\Extractor;
  8. use Knuckles\Scribe\Tests\Fixtures\TestController;
  9. use Knuckles\Scribe\Tools\DocumentationConfig;
  10. use PHPUnit\Framework\TestCase;
  11. class ExtractorTest extends TestCase
  12. {
  13. use ArraySubsetAsserts;
  14. protected Extractor $extractor;
  15. protected $config = [
  16. 'strategies' => [
  17. 'metadata' => [
  18. \Knuckles\Scribe\Extracting\Strategies\Metadata\GetFromDocBlocks::class,
  19. \Knuckles\Scribe\Tests\Fixtures\TestCustomEndpointMetadata::class,
  20. ],
  21. 'urlParameters' => [
  22. \Knuckles\Scribe\Extracting\Strategies\UrlParameters\GetFromLaravelAPI::class,
  23. \Knuckles\Scribe\Extracting\Strategies\UrlParameters\GetFromUrlParamTag::class,
  24. ],
  25. 'queryParameters' => [
  26. \Knuckles\Scribe\Extracting\Strategies\QueryParameters\GetFromQueryParamTag::class,
  27. ],
  28. 'headers' => [
  29. \Knuckles\Scribe\Extracting\Strategies\Headers\GetFromRouteRules::class,
  30. \Knuckles\Scribe\Extracting\Strategies\Headers\GetFromHeaderTag::class,
  31. ],
  32. 'bodyParameters' => [
  33. \Knuckles\Scribe\Extracting\Strategies\BodyParameters\GetFromBodyParamTag::class,
  34. ],
  35. 'responses' => [
  36. \Knuckles\Scribe\Extracting\Strategies\Responses\UseResponseTag::class,
  37. \Knuckles\Scribe\Extracting\Strategies\Responses\UseResponseFileTag::class,
  38. \Knuckles\Scribe\Extracting\Strategies\Responses\ResponseCalls::class,
  39. ],
  40. 'responseFields' => [
  41. \Knuckles\Scribe\Extracting\Strategies\ResponseFields\GetFromResponseFieldTag::class,
  42. ],
  43. ],
  44. ];
  45. /**
  46. * Setup the test environment.
  47. */
  48. public function setUp(): void
  49. {
  50. parent::setUp();
  51. $this->extractor = new Extractor(new DocumentationConfig($this->config));
  52. }
  53. /** @test */
  54. public function clean_can_properly_parse_array_keys()
  55. {
  56. $parameters = Parameter::arrayOf([
  57. 'object' => [
  58. 'name' => 'object',
  59. 'type' => 'object',
  60. 'example' => [],
  61. ],
  62. 'object.key1' => [
  63. 'name' => 'object.key1',
  64. 'type' => 'string',
  65. 'example' => '43',
  66. ],
  67. 'object.key2' => [
  68. 'name' => 'object.key2',
  69. 'type' => 'integer',
  70. 'example' => 77,
  71. ],
  72. 'object.key3' => [
  73. 'name' => 'object.key3',
  74. 'type' => 'object',
  75. 'example'=> [],
  76. ],
  77. 'object.key3.key1' => [
  78. 'name' => 'object.key3.key1',
  79. 'type' => 'string',
  80. 'example' => 'hoho',
  81. ],
  82. 'list' => [
  83. 'name' => 'list',
  84. 'type' => 'integer[]',
  85. 'example' => [4],
  86. ],
  87. 'list_of_objects' => [
  88. 'name' => 'list_of_objects',
  89. 'type' => 'object[]',
  90. 'example' => [[]],
  91. ],
  92. 'list_of_objects[].key1' => [
  93. 'name' => 'list_of_objects.key1',
  94. 'type' => 'string',
  95. 'required' => true,
  96. 'example' => 'John',
  97. ],
  98. 'list_of_objects[].key2' => [
  99. 'name' => 'list_of_objects.key2',
  100. 'type' => 'boolean',
  101. 'required' => true,
  102. 'example' => false,
  103. ],
  104. ]);
  105. $cleanBodyParameters = Extractor::cleanParams($parameters);
  106. $this->assertEquals([
  107. 'object' => [
  108. 'key1' => '43',
  109. 'key2' => 77,
  110. 'key3' => [
  111. 'key1' => 'hoho'
  112. ]
  113. ],
  114. 'list' => [4],
  115. 'list_of_objects' => [
  116. [
  117. 'key1' => 'John',
  118. 'key2' => false,
  119. ],
  120. ],
  121. ], $cleanBodyParameters);
  122. }
  123. /** @test */
  124. public function does_not_generate_values_for_excluded_params_and_excludes_them_from_clean_params()
  125. {
  126. $route = $this->createRouteOldSyntax('POST', '/api/test', 'withExcludedExamples');
  127. $parsed = $this->extractor->processRoute($route)->toArray();
  128. $cleanBodyParameters = $parsed['cleanBodyParameters'];
  129. $cleanQueryParameters = $parsed['cleanQueryParameters'];
  130. $bodyParameters = $parsed['bodyParameters'];
  131. $queryParameters = $parsed['queryParameters'];
  132. $this->assertArrayHasKey('included', $cleanBodyParameters);
  133. $this->assertArrayNotHasKey('excluded_body_param', $cleanBodyParameters);
  134. $this->assertEmpty($cleanQueryParameters);
  135. $this->assertArraySubset([
  136. 'included' => [
  137. 'required' => true,
  138. 'type' => 'string',
  139. 'description' => 'Exists in examples.',
  140. ],
  141. 'excluded_body_param' => [
  142. 'type' => 'integer',
  143. 'description' => 'Does not exist in examples.',
  144. ],
  145. ], $bodyParameters);
  146. $this->assertArraySubset([
  147. 'excluded_query_param' => [
  148. 'description' => 'Does not exist in examples.',
  149. ],
  150. ], $queryParameters);
  151. }
  152. /** @test */
  153. public function can_parse_route_methods()
  154. {
  155. $route = $this->createRouteOldSyntax('GET', '/get', 'withEndpointDescription');
  156. $parsed = $this->extractor->processRoute($route);
  157. $this->assertEquals(['GET'], $parsed->httpMethods);
  158. $route = $this->createRouteOldSyntax('POST', '/post', 'withEndpointDescription');
  159. $parsed = $this->extractor->processRoute($route);
  160. $this->assertEquals(['POST'], $parsed->httpMethods);
  161. $route = $this->createRouteOldSyntax('PUT', '/put', 'withEndpointDescription');
  162. $parsed = $this->extractor->processRoute($route);
  163. $this->assertEquals(['PUT'], $parsed->httpMethods);
  164. $route = $this->createRouteOldSyntax('DELETE', '/delete', 'withEndpointDescription');
  165. $parsed = $this->extractor->processRoute($route);
  166. $this->assertEquals(['DELETE'], $parsed->httpMethods);
  167. }
  168. /**
  169. * @test
  170. * @dataProvider authRules
  171. */
  172. public function adds_appropriate_field_based_on_configured_auth_type($config, $expected)
  173. {
  174. $route = $this->createRouteOldSyntax('POST', '/withAuthenticatedTag', 'withAuthenticatedTag');
  175. $generator = new Extractor(new DocumentationConfig(array_merge($this->config, $config)));
  176. $parsed = $generator->processRoute($route, [])->toArray();
  177. $this->assertNotNull($parsed[$expected['where']][$expected['name']]);
  178. $this->assertEquals($expected['where'], $parsed['auth'][0]);
  179. $this->assertEquals($expected['name'], $parsed['auth'][1]);
  180. }
  181. /** @test */
  182. public function generates_consistent_examples_when_faker_seed_is_set()
  183. {
  184. $route = $this->createRouteOldSyntax('POST', '/withBodyParameters', 'withBodyParameters');
  185. $paramName = 'room_id';
  186. $results = [];
  187. $results[$this->extractor->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  188. $results[$this->extractor->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  189. $results[$this->extractor->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  190. $results[$this->extractor->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  191. $results[$this->extractor->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  192. // Examples should have different values
  193. $this->assertNotEquals(1, count($results));
  194. $generator = new Extractor(new DocumentationConfig($this->config + ['examples' => ['faker_seed' => 12345]]));
  195. $results = [];
  196. $results[$generator->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  197. $results[$generator->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  198. $results[$generator->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  199. $results[$generator->processRoute($route)->cleanBodyParameters[$paramName]] = true;
  200. // Examples should have same values
  201. $this->assertEquals(1, count($results));
  202. }
  203. /** @test */
  204. public function can_use_arrays_in_routes_uses()
  205. {
  206. $route = $this->createRoute('GET', '/api/array/test', 'withEndpointDescription');
  207. $parsed = $this->extractor->processRoute($route);
  208. $this->assertSame('Example title.', $parsed->metadata->title);
  209. $this->assertSame("This will be the long description.\nIt can also be multiple lines long.", $parsed->metadata->description);
  210. }
  211. /** @test */
  212. public function can_use_closure_in_routes_uses()
  213. {
  214. /**
  215. * A short title.
  216. * A longer description.
  217. * Can be multiple lines.
  218. *
  219. * @queryParam location_id required The id of the location.
  220. * @bodyParam name required Name of the location
  221. */
  222. $handler = fn () => 'hi';
  223. $route = $this->createClosureRoute('POST', '/api/closure/test', $handler);
  224. $parsed = $this->extractor->processRoute($route);
  225. $this->assertSame('A short title.', $parsed->metadata->title);
  226. $this->assertSame("A longer description.\nCan be multiple lines.", $parsed->metadata->description);
  227. $this->assertCount(1, $parsed->queryParameters);
  228. $this->assertCount(1, $parsed->bodyParameters);
  229. $this->assertSame('The id of the location.', $parsed->queryParameters['location_id']->description);
  230. $this->assertSame('Name of the location', $parsed->bodyParameters['name']->description);
  231. }
  232. /** @test */
  233. public function endpoint_metadata_supports_custom_declarations()
  234. {
  235. $route = $this->createRouteOldSyntax('POST', '/api/test', 'dummy');
  236. $parsed = $this->extractor->processRoute($route);
  237. $this->assertSame('some custom metadata', $parsed->metadata->custom['myProperty']);
  238. }
  239. /** @test */
  240. public function can_override_data_for_inherited_methods()
  241. {
  242. $route = $this->createRoute('POST', '/api/test', 'endpoint', TestParentController::class);
  243. $parent = $this->extractor->processRoute($route);
  244. $this->assertSame('Parent title', $parent->metadata->title);
  245. $this->assertSame('Parent group name', $parent->metadata->groupName);
  246. $this->assertSame('Parent description', $parent->metadata->description);
  247. $this->assertCount(1, $parent->responses);
  248. $this->assertCount(1, $parent->bodyParameters);
  249. $this->assertArraySubset(["type" => "integer"], $parent->bodyParameters['thing']->toArray());
  250. $this->assertEmpty($parent->queryParameters);
  251. $inheritedRoute = $this->createRoute('POST', '/api/test', 'endpoint', TestInheritedController::class);
  252. $inherited = $this->extractor->processRoute($inheritedRoute);
  253. $this->assertSame('Overridden title', $inherited->metadata->title);
  254. $this->assertSame('Overridden group name', $inherited->metadata->groupName);
  255. $this->assertSame('Parent description', $inherited->metadata->description);
  256. $this->assertCount(0, $inherited->responses);
  257. $this->assertCount(2, $inherited->bodyParameters);
  258. $this->assertArraySubset(["type" => "integer"], $inherited->bodyParameters['thing']->toArray());
  259. $this->assertArraySubset(["type" => "string"], $inherited->bodyParameters["other_thing"]->toArray());
  260. $this->assertCount(1, $inherited->queryParameters);
  261. $this->assertArraySubset(["type" => "string"], $inherited->queryParameters["queryThing"]->toArray());
  262. }
  263. public function createRoute(string $httpMethod, string $path, string $controllerMethod, $class = TestController::class)
  264. {
  265. return new Route([$httpMethod], $path, ['uses' => [$class, $controllerMethod]]);
  266. }
  267. public function createRouteOldSyntax(string $httpMethod, string $path, string $controllerMethod, $class = TestController::class)
  268. {
  269. return new Route([$httpMethod], $path, ['uses' => $class . "@$controllerMethod"]);
  270. }
  271. public function createClosureRoute(string $httpMethod, string $path, callable $handler)
  272. {
  273. return new Route([$httpMethod], $path, ['uses' => $handler]);
  274. }
  275. public function authRules()
  276. {
  277. return [
  278. [
  279. [
  280. 'auth' => [
  281. 'enabled' => true,
  282. 'in' => 'bearer',
  283. 'name' => 'dfadb',
  284. ]
  285. ],
  286. [
  287. 'name' => 'Authorization',
  288. 'where' => 'headers',
  289. ]
  290. ],
  291. [
  292. [
  293. 'auth' => [
  294. 'enabled' => true,
  295. 'in' => 'basic',
  296. 'name' => 'efwr',
  297. ]
  298. ],
  299. [
  300. 'name' => 'Authorization',
  301. 'where' => 'headers',
  302. ]
  303. ],
  304. [
  305. [
  306. 'auth' => [
  307. 'enabled' => true,
  308. 'in' => 'header',
  309. 'name' => 'Api-Key',
  310. ]
  311. ],
  312. [
  313. 'name' => 'Api-Key',
  314. 'where' => 'headers',
  315. ]
  316. ],
  317. [
  318. [
  319. 'auth' => [
  320. 'enabled' => true,
  321. 'in' => 'query',
  322. 'name' => 'apiKey',
  323. ]
  324. ],
  325. [
  326. 'name' => 'apiKey',
  327. 'where' => 'queryParameters',
  328. ]
  329. ],
  330. [
  331. [
  332. 'auth' => [
  333. 'enabled' => true,
  334. 'in' => 'body',
  335. 'name' => 'access_token',
  336. ]
  337. ],
  338. [
  339. 'name' => 'access_token',
  340. 'where' => 'bodyParameters',
  341. ]
  342. ],
  343. ];
  344. }
  345. }
  346. class TestParentController
  347. {
  348. /**
  349. * Parent title
  350. *
  351. * Parent description
  352. *
  353. * @group Parent group name
  354. *
  355. * @bodyParam thing integer
  356. * @response {"hello":"there"}
  357. */
  358. public function endpoint()
  359. {
  360. }
  361. }
  362. class TestInheritedController extends TestParentController
  363. {
  364. public static function inheritedDocsOverrides()
  365. {
  366. return [
  367. "endpoint" => [
  368. "metadata" => [
  369. "title" => "Overridden title",
  370. "groupName" => "Overridden group name",
  371. ],
  372. "queryParameters" => function (ExtractedEndpointData $endpointData) {
  373. // Overrides
  374. return [
  375. 'queryThing' => [
  376. 'type' => 'string',
  377. ],
  378. ];
  379. },
  380. "bodyParameters" => [
  381. // Merges
  382. "other_thing" => [
  383. "type" => "string",
  384. ],
  385. ],
  386. "responses" => function (ExtractedEndpointData $endpointData) {
  387. // Completely overrides responses
  388. return [];
  389. },
  390. ],
  391. ];
  392. }
  393. }